BASH PATCH REPORT ================= Bash-Release: 3.0 Patch-ID: bash30-020 Bug-Reported-by: Florian Weimer Bug-Reference-ID: Bug-Reference-URL: Bug-Description: There are two local buffer overflows in parse.y that can cause the shell to dump core when given many here-documents attached to a single command or many nested loops. Patch: *** ../bash-3.0.19/parse.y 2014-09-27 12:16:05.000000000 -0400 --- parse.y 2014-09-30 19:53:28.000000000 -0400 *************** *** 166,169 **** --- 166,172 ---- static int reserved_word_acceptable __P((int)); static int yylex __P((void)); + + static void push_heredoc __P((REDIRECT *)); + static char *mk_alexpansion __P((char *)); static int alias_expand_token __P((char *)); static int time_command_acceptable __P((void)); *************** *** 258,262 **** /* Variables to manage the task of reading here documents, because we need to defer the reading until after a complete command has been collected. */ ! static REDIRECT *redir_stack[10]; int need_here_doc; --- 261,267 ---- /* Variables to manage the task of reading here documents, because we need to defer the reading until after a complete command has been collected. */ ! #define HEREDOC_MAX 16 ! ! static REDIRECT *redir_stack[HEREDOC_MAX]; int need_here_doc; *************** *** 284,288 **** index is decremented after a case, select, or for command is parsed. */ #define MAX_CASE_NEST 128 ! static int word_lineno[MAX_CASE_NEST]; static int word_top = -1; --- 289,293 ---- index is decremented after a case, select, or for command is parsed. */ #define MAX_CASE_NEST 128 ! static int word_lineno[MAX_CASE_NEST+1]; static int word_top = -1; *************** *** 429,433 **** redir.filename = $2; $$ = make_redirection (0, r_reading_until, redir); ! redir_stack[need_here_doc++] = $$; } | NUMBER LESS_LESS WORD --- 434,438 ---- redir.filename = $2; $$ = make_redirection (0, r_reading_until, redir); ! push_heredoc ($$); } | NUMBER LESS_LESS WORD *************** *** 435,439 **** redir.filename = $3; $$ = make_redirection ($1, r_reading_until, redir); ! redir_stack[need_here_doc++] = $$; } | LESS_LESS_LESS WORD --- 440,444 ---- redir.filename = $3; $$ = make_redirection ($1, r_reading_until, redir); ! push_heredoc ($$); } | LESS_LESS_LESS WORD *************** *** 492,496 **** $$ = make_redirection (0, r_deblank_reading_until, redir); ! redir_stack[need_here_doc++] = $$; } | NUMBER LESS_LESS_MINUS WORD --- 497,501 ---- $$ = make_redirection (0, r_deblank_reading_until, redir); ! push_heredoc ($$); } | NUMBER LESS_LESS_MINUS WORD *************** *** 499,503 **** $$ = make_redirection ($1, r_deblank_reading_until, redir); ! redir_stack[need_here_doc++] = $$; } | GREATER_AND '-' --- 504,508 ---- $$ = make_redirection ($1, r_deblank_reading_until, redir); ! push_heredoc ($$); } | GREATER_AND '-' *************** *** 2194,2197 **** --- 2199,2217 ---- static int esacs_needed_count; + static void + push_heredoc (r) + REDIRECT *r; + { + if (need_here_doc >= HEREDOC_MAX) + { + last_command_exit_value = EX_BADUSAGE; + need_here_doc = 0; + report_syntax_error (_("maximum here-document count exceeded")); + reset_parser (); + exit_shell (last_command_exit_value); + } + redir_stack[need_here_doc++] = r; + } + void gather_here_documents () *** ../bash-3.0/patchlevel.h Wed Aug 22 08:05:39 2001 --- patchlevel.h Thu Sep 2 15:04:32 2004 *************** *** 26,30 **** looks for to find the patch level (for the sccs version string). */ ! #define PATCHLEVEL 19 #endif /* _PATCHLEVEL_H_ */ --- 26,30 ---- looks for to find the patch level (for the sccs version string). */ ! #define PATCHLEVEL 20 #endif /* _PATCHLEVEL_H_ */